fix(release): remove bypass and enforce tag-based dynamic versioning#21
Merged
fix(release): remove bypass and enforce tag-based dynamic versioning#21
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens release-time versioning by removing a CI bypass and relying on strict, tag-based version resolution via poetry-dynamic-versioning, aiming to make releases deterministic and fail-fast on misconfiguration.
Changes:
- Updated
pyproject.tomlto require the dynamic-versioning plugin, enforce strict tag-based resolution, and support unprefixed SemVer tags. - Removed the explicit
poetry dynamic-versioningstep from the release workflow, relying on plugin/backend behavior during build. - Added a
1.3.6changelog entry describing the final versioning strategy.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Adds plugin requirements and strict/unprefixed tag configuration for dynamic versioning. |
CHANGELOG.md |
Documents the determinism/versioning strategy changes in a new release entry. |
.github/workflows/release.yml |
Removes the redundant explicit dynamic-versioning command step before poetry build. |
e180329 to
d5b61d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The release pipeline must fail fast on versioning misconfiguration instead of silently producing incorrect versions.
By relying on strict tag-based configuration (including unprefixed tag matching) instead of a CI-only override, releases become deterministic and easier to reason about.
Version impact