Skip to content

fix(release): remove bypass and enforce tag-based dynamic versioning#21

Merged
eschaar merged 1 commit intomainfrom
fix/release-versioning-config-cleanup
Apr 22, 2026
Merged

fix(release): remove bypass and enforce tag-based dynamic versioning#21
eschaar merged 1 commit intomainfrom
fix/release-versioning-config-cleanup

Conversation

@eschaar
Copy link
Copy Markdown
Owner

@eschaar eschaar commented Apr 22, 2026

Summary

  • Removed release-time bypass override so package versioning resolves from git tags via poetry-dynamic-versioning configuration.
  • Kept CI plugin installation and tag-pinned checkout flow, while removing the redundant dynamic-versioning command step.
  • Updated project packaging config for cleaner Poetry/PEP 621 behavior and aligned changelog notes with the final strategy.

Why

The release pipeline must fail fast on versioning misconfiguration instead of silently producing incorrect versions.
By relying on strict tag-based configuration (including unprefixed tag matching) instead of a CI-only override, releases become deterministic and easier to reason about.

Version impact

  • Patch
  • Minor
  • Major
  • None

Copilot AI review requested due to automatic review settings April 22, 2026 20:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens release-time versioning by removing a CI bypass and relying on strict, tag-based version resolution via poetry-dynamic-versioning, aiming to make releases deterministic and fail-fast on misconfiguration.

Changes:

  • Updated pyproject.toml to require the dynamic-versioning plugin, enforce strict tag-based resolution, and support unprefixed SemVer tags.
  • Removed the explicit poetry dynamic-versioning step from the release workflow, relying on plugin/backend behavior during build.
  • Added a 1.3.6 changelog entry describing the final versioning strategy.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Adds plugin requirements and strict/unprefixed tag configuration for dynamic versioning.
CHANGELOG.md Documents the determinism/versioning strategy changes in a new release entry.
.github/workflows/release.yml Removes the redundant explicit dynamic-versioning command step before poetry build.

Comment thread pyproject.toml
@eschaar eschaar force-pushed the fix/release-versioning-config-cleanup branch from e180329 to d5b61d5 Compare April 22, 2026 20:10
@eschaar eschaar merged commit 1c2d3c7 into main Apr 22, 2026
12 checks passed
@eschaar eschaar deleted the fix/release-versioning-config-cleanup branch April 22, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants