Support manual connect for configured MCP servers#2503
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5262ad81b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit MCP auto-start control and a manual connect path:
[[plugins]].auto_start = falsekeeps a configured MCP server from connecting during session startup./mcp connect <name>connects a configured but currently disconnected server on demand.reasonix mcp listshows[auto_start=false]for disabled startup entries./mcp connectand suggests disconnected configured server names..mcp.jsonimports preserveauto_startwhen present.Root Cause
Some MCP servers are useful but heavy, flaky, auth-bound, or only needed occasionally. Starting every configured server on every session makes startup slower and can introduce unnecessary provider-visible tool schema churn.
Technical Approach
PluginEntry.AutoStart *boolso omitted values preserve historical auto-start behavior.PluginEntry.ShouldAutoStart()andConfig.AutoStartPlugins().AutoStartPlugins().ConnectConfiguredMCPServer./mcp connectchat handling and structured slash completion..mcp.jsonparsing tests forauto_start=false.Focused Optimization Points
auto_startis tri-state by using*bool: nil keeps current behavior, false opts out, true can be rendered/preserved.Cache / Tool Schema Notes
This PR intentionally lets users keep configured MCP servers out of the startup tool schema with
auto_start=false. That can improve cache stability for heavy or rarely used servers, but connecting one manually changes the provider-visible tool set on the next model turn, matching existing live/mcp addbehavior.Verification
Passed:
go test ./internal/config ./internal/control ./internal/cli ./internal/acp ./internal/boot -run 'TestPlugin|TestAutoStart|TestMCP|TestSlashArg|TestBuildWithoutMemoryLeavesPromptUnchanged|TestRenderTOML|TestLoadMCP|TestMergeMCP|TestProtocol'go test ./internal/agent -run TestPlanModeDoesNotMutateSystemOrTools