fix(desktop): don't submit on IME confirm Enter#2632
Merged
esengine merged 1 commit intoJun 2, 2026
Conversation
github-actions
Bot
added
the
v2
esengine
pushed a commit
that referenced
this pull request
Jun 2, 2026
Follow-up to #2632. The grace window only needs to span the same Enter straddling compositionend (a few ms); 250ms also swallowed a deliberate quick second Enter meant to submit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop composer still had an IME edge case: confirming text with Enter can sometimes look like a normal Enter key press.
This can happen when the keydown arrives just after
compositionend, or when the browser reports the IME key event askeyCode === 229. In that case, pressing Enter to confirm text with a CJK IME may submit the prompt, or pick the active slash/@ menu item, instead of just committing the text.This change keeps a small grace window after composition ends and treats
keyCode === 229as IME input. The guard runs before the composer handles Enter for menu picks or submit.Related: #1645, #1689
Not the same path as #2297, which is about the Ink/TUI input.
Checked:
npm --prefix desktop/frontend run typechecknpm --prefix desktop/frontend run buildManual check:
github.