feat(mcp): lifecycle line cards match design doc §37 (Stage A of #105)#106
Merged
feat(mcp): lifecycle line cards match design doc §37 (Stage A of #105)#106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage A of #105.
What
Replace the two ad-hoc startup strings in
chat.tsxandrun.tswith the lifecycle vocabulary documented indocs/design/agent-tui-terminal.html§37. This stage wires the three states that already fire today; B and C will wire the rest.Before:
After:
Why
The runtime drifted from the design doc. This stage closes the gap on lifecycle vocabulary and lays the formatter that Stage B (browser modal) and Stage C (disable / enable / reconnect / slow-toast) will reuse.
Touch
src/cli/ui/mcp-lifecycle.tsexporting a typedformatMcpLifecycleEventso chat / run / future surfaces share one formatter.src/cli/commands/chat.tsx: emithandshakebeforemcp.initialize(), emitconnectedafter bridge + inspect with resource / prompt counts and elapsed ms, emitfailedin the catch path.src/cli/commands/run.ts: same pattern.tests/mcp-lifecycle.test.ts: 6 cases pinning the layout (column alignment for short/long names, minimum-gap fallback, no embedded newlines).Test plan
npm run verifypasses locally (1737 tests, lint, typecheck, build)▸ MCP[...]/▸ MCP setup SKIPPEDformat outside the two files I'm editing (greppable)npm run dev chat --mcp ...startup against the design §37 mockup