Fix error in kubed-display-resource-revert #21
Closed
MagielBruntink wants to merge 1 commit into
Closed
Conversation
…tents rather than replace-buffer-contents.
eshelyaron
added a commit
that referenced
this pull request
Jun 19, 2026
We recently switched to using 'replace-region-contents' instead of 'replace-buffer-contents', because the latter is deprecated in Emacs 31. However, the way we call 'replace-region-contents' is only valid since Emacs 31, so it failed on Emacs 30. Reported in #21 * kubed.el (kubed--replace-buffer-contents): New function. (kubed-display-resource-revert, kubed-display-config): Use it.
Owner
|
Hi there @MagielBruntink , thanks for the PR! |
Author
|
I have tried the latest master and can confirm that it resolves the issue. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubed-display-resource-revert calls replace-region-contents, I think erroneously. Upon requesting a resource to be displayed, there is an error like the following, which is due to the buffer being used as replace-fn argument.
This PR changes that call to replace-buffer-contents instead, which resolved the problem.