Conversation
|
Disregard the 3rd commit. I forgot to make a branch for my changes. |
|
Hi, thank you very much, sorry for the late response! I'm new to Rust so these kind of PRs help me a lot. I went ahead and cherry-picked your first two commits. The third commit also looks really good and I'd love to have those changes as well, but I'll hold off on it as you ask. From a cursory look, it seems like the top-level dvorak/qwerty keybind options aren't being read in the new Config::from_toml(). Let me know when you're ready, feel free to open a new PR or update your fork. If you're interested, I would like to add you as a collaborator on this repo to make it easier for you to continue your great refactoring work. |
|
The serde stuff is not very thought out, and relies on a Alpha build of Ratatui, but I'm glad you liked my changes. I am very inexperienced with git, so hope it's not too scuffed. :) |
|
The qwerty / Dvorak stuff can be added back in with some |
|
Do I close this now or? since you cherry picked it? This is my first pull request, so I don't know how this works. |
|
Sure, I have some free time now and I'm ready to work on improving the config parsing. i'll close this now. |
Added the type ConfigError.
All methods on the Config struct has better error handeling.
moved a function to view.rs
Theme struct now implements From