allow using arrays when defining keybindings#9
Merged
eshrh merged 2 commits intoeshrh:masterfrom Jan 8, 2025
Merged
Conversation
this is needed because the current way is not toml complient current way still works for backwards compatability
Owner
|
Thanks, this is great! |
Owner
|
I removed the suggestion to use duplicate keybindings from the documention; not only is this just better, using multiple keys doesn't actually work (the toml parser errors; i just never tested it): 8c54009 |
Contributor
|
On the topic of nix, I've opened NixOS/nixpkgs#371762 packaging inori. Feel free to +1 / review. @eshrh and I both use nixos, so an upstream home-manager module is potentially in the works (currently blocked on the nixpkgs PR, of course). If you write something for your own configuration that's worth sharing, feel free to ping us. |
Contributor
Author
|
i looked a bit into it, only had to do some minor cleanup. now just gotta figure out how to contribute that. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is needed because the current way is not toml compliant
i wouldnt care much about toml compliancy but i want to be able to generate the config through home-manager
tested, works flawlessly on my machine™