Closed
Conversation
| {:exometer, github: "PSPDFKit-labs/exometer"}, | ||
| {:elixometer, github: "pinterest/elixometer"}, | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
There should be no more than 1 consecutive blank lines.
| defmodule MongoosePush.Metrics do | ||
| use Elixometer | ||
|
|
||
| def update(return_value, metric_prefix, value \\ 1) do |
Contributor
There was a problem hiding this comment.
Functions should have a @SPEC type specification.
| @@ -0,0 +1,24 @@ | |||
| defmodule MongoosePush.Metrics do | |||
| push_result = module.push(notification, device_id, worker, opts) | ||
|
|
||
| push_result | ||
| |> MongoosePush.Metrics.update(~s"push.#{service}.#{mode}") |
Contributor
There was a problem hiding this comment.
Nested modules could be aliased at the top of the invoking module.
Contributor
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/esl/MongoosePush/pulls/7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add metrics support to MongoosePush. For now this PR is only for build on travis.