Conversation
rslota
force-pushed
the
rs/otp21-compile-fix
branch
4 times, most recently
from
cc7ed44 to
76e8087
Compare
kanes115
approved these changes
Apr 11, 2019
Contributor
There was a problem hiding this comment.
I think this would be worth noting somewhere (in README.md for example) that there are problems with versions of erlang 20.3.X (where X < 2) to save future contributors' time. It is not so obvious to deduce that there are CIPHER suites problems in TLS handshake with APNS.
rslota
force-pushed
the
rs/otp21-compile-fix
branch
2 times, most recently
from
f5cc8f6 to
fd80324
Compare
Contributor
Author
Thanks for the suggestion! I've added a small note to |
* Dependencies have been updated so that project compiles with Erlang/OTP 21.3 * Travis matrix has been updated to test and deploy with Erlang/OTP 21.3 * Travis matrix has been updated to test and deploy with Elixir 1.7.x (Elixir 1.8.x is temporarly incompatible due to Travis issues with the build) * Version of MongoosePush changes to 1.0.2 as the official Docker image is now based on newer Elixir/Erlang platform
rslota
force-pushed
the
rs/otp21-compile-fix
branch
from
fd80324 to
5eb1175
Compare
rslota
pushed a commit
that referenced
this pull request
Nov 21, 2019
* Dependencies have been updated so that project compiles with Erlang/OTP 21.3 * Travis matrix has been updated to test and deploy with Erlang/OTP 21.3 * Travis matrix has been updated to test and deploy with Elixir 1.7.x (Elixir 1.8.x is temporarly incompatible due to Travis issues with the build) * Version of MongoosePush changes to 1.0.2 as the official Docker image is now based on newer Elixir/Erlang platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Elixir 1.8.x is temporarly incompatible due to Travis issues with the
build)
is now based on newer Elixir/Erlang platform