Skip to content

Add missing specs#275

Merged
DenysGonchar merged 3 commits intomasterfrom
missing_specs
Jan 20, 2025
Merged

Add missing specs#275
DenysGonchar merged 3 commits intomasterfrom
missing_specs

Conversation

@NelsonVides
Copy link
Copy Markdown
Contributor

@NelsonVides NelsonVides commented Jan 20, 2025

Many added specs are not refined, I just added term() or equivalent when the type wasn't obvious. Many types are very specific though. This will at least clean MIM compilation warnings.

@NelsonVides NelsonVides changed the title Add missing specs to escalus_stanza module Add missing specs Jan 20, 2025
@NelsonVides NelsonVides force-pushed the missing_specs branch 2 times, most recently from b232cb1 to d6c7981 Compare January 20, 2025 12:57
@NelsonVides NelsonVides marked this pull request as ready for review January 20, 2025 12:59
Copy link
Copy Markdown
Contributor

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

Comment thread src/escalus_pubsub_stanza.erl
@DenysGonchar DenysGonchar merged commit 3b71af1 into master Jan 20, 2025
@NelsonVides NelsonVides deleted the missing_specs branch January 20, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants