Skip to content

feat: support Math in Markdown#299

Draft
lumirlumir wants to merge 5 commits intomainfrom
lumirlumir-patch-1
Draft

feat: support Math in Markdown#299
lumirlumir wants to merge 5 commits intomainfrom
lumirlumir-patch-1

Conversation

@lumirlumir
Copy link
Copy Markdown
Member

@lumirlumir lumirlumir commented Jan 27, 2026

Prerequisites checklist

What is the purpose of this pull request?

This PR updates Code Explorer to support the Math parsing option for the Markdown language, introduced in eslint/markdown#617 and released as part of @eslint/markdown v8.

What changes did you make? (Give an overview)

I've also updated e2e-tests/options.test.ts to test various language options which was previously missing, as well as the test for newly added Math option. I've also used test.step to clearly indicate the current step in the e2e test.

Related Issues

Ref: eslint/markdown#331

Is there anything you'd like reviewers to focus on?

N/A

@eslintbot eslintbot added this to Triage Jan 27, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 27, 2026
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Jan 27, 2026
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jan 27, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 27, 2026

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit 8881315
🔍 Latest deploy log https://app.netlify.com/projects/eslint-code-explorer/deploys/69cb48f4573dd1000884fd41
😎 Deploy Preview https://deploy-preview-299--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ayatobai
Copy link
Copy Markdown

@lumirlumir, I wanted to share some constructive feedback on your PRs:

  1. I’ve noticed that refactors and fixes/features are sometimes combined in the same PR. Splitting these into separate PRs would make the logic changes easier to review and merge.
  2. Tasks like this one seem to be taking a few hours, where I’d expect something closer to ~30 minutes. I’d suggest utilizing AI tools for the boilerplate and tests to help speed things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion feature

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

3 participants