chore: update tsconfig target from es5 to es2022#363
Merged
Conversation
The `target: "es5"` was a leftover from the original Create React App scaffold and has been misleading since the project migrated to Vite. Vite explicitly ignores `tsconfig.json` target — it uses `build.target` in vite.config.ts for actual browser output (defaulting to `baseline-widely-available`). The tsconfig target only affects: - What TypeScript's type-checker considers valid syntax - IDE autocompletion and inline error hints `es2022` aligns the tsconfig with what Vite actually emits, enables the correct `useDefineForClassFields: true` default, and removes misleading IDE signals that modern syntax is disallowed."
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
The
target: "es5"was a leftover from the original Create React App scaffold and has been misleading since the project migrated to Vite.Vite explicitly ignores
tsconfig.jsontarget — it usesbuild.targetin vite.config.ts for actual browser output (defaulting tobaseline-widely-available). The tsconfig target only affects:Docs reference - https://vite.dev/guide/features#target
What changes did you make? (Give an overview)
es2022aligns the tsconfig with what Vite actually emits, enables the correctuseDefineForClassFields: truedefault, and removes misleading IDE signals that modern syntax is disallowed."Related Issues
Is there anything you'd like reviewers to focus on?