Skip to content

Change Request: Use consistent Node.js LTS version in CI Build install workflow #98

@MikeMcC399

Description

@MikeMcC399

Environment

Repo's CI environment

ESLint version: eslint@^9.11.1 unlocked
@eslint/css version: v0.5.0
Node version: 20.19.0 and 22.14.0
npm version: 10.8.2 and 10.9.2
Operating System: ubuntu-latest / ubuntu-24.04

What problem do you want to solve?

The jobs:

  • yarn-install
  • pnpm-install

in the workflow .github/workflows/ci-build-all-pm.yml pin the Node.js version to 22.14.0 in order to ensure a minimum corepack@0.31.0 was available.

This provided a fix for pnpm installation issues (see pnpm/pnpm#9029) and was a precaution for Yarn installation.

This pinning is inconsistent with the other jobs in the workflow, which are using GitHub Action ubuntu-latest / ubuntu-24.04 default Node.js version 20.19.0.

It is also inconsistent with the main CI workflow which uses node-version: "lts/*" (although at the moment lts is equivalent to 22.14.0).

What do you think is the correct solution?

Add actions/setup-node@v4 to each job in .github/workflows/ci-build-all-pm.yml where it is missing and set all jobs to use the Node.js Active LTS version. (This version remains good for Corepack.)

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

Metadata

Metadata

Assignees

Labels

acceptedThere is consensus among the team that this change meets the criteria for inclusionenhancementNew feature or request

Type

No type

Projects

Status

Complete

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions