Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Dec 2, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR was motivated by #187 (comment).

Currently, when updating @eslint/core to v1.0.0, CI fails because @eslint/core@1.0.0 does not match ESLint v9

@eslint/core@1.0.0 includes type information for ESLint v10, which causes the type mismatch.

So, I've updated ESLint to >=10.0.0-alpha.0 <10.0.0 || ^10.0.1. (Ref: https://github.com/eslint/eslint/blob/main/packages/eslint-config-eslint/package.json#L66)


When I update ESLint to >=10.0.0-alpha.0 <10.0.0 || ^10.0.1, the following error occurs, so I added the legacy-peer-deps option to .npmrc.

This change follows the approach in eslint/eslint#20281

image

What changes did you make? (Give an overview)

In this PR, I've updated @eslint/core, add legacy-peer-deps, and use ESLint v10 pre-release.

Related Issues

Ref: #187, #187 (comment), eslint/eslint#20281

Is there anything you'd like reviewers to focus on?

N/A

@eslintbot eslintbot added this to Triage Dec 2, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 2, 2025
@lumirlumir lumirlumir changed the title chore: update dependency @eslint/core to v1 chore: update @eslint/core to v1 and add legacy-peer-deps to .npmrc Dec 2, 2025
@eslint-github-bot
Copy link

Hi @lumirlumir!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@lumirlumir lumirlumir changed the title chore: update @eslint/core to v1 and add legacy-peer-deps to .npmrc chore: update @eslint/core to v1 and add legacy-peer-deps Dec 2, 2025
@lumirlumir lumirlumir changed the title chore: update @eslint/core to v1 and add legacy-peer-deps chore: update @eslint/core, add legacy-peer-deps, and use ESLint v10 prerelease Dec 2, 2025
@eslint-github-bot
Copy link

Hi @lumirlumir!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@lumirlumir lumirlumir changed the title chore: update @eslint/core, add legacy-peer-deps, and use ESLint v10 prerelease chore: update @eslint/core, add legacy-peer-deps, and use ESLint v10 Dec 2, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From ESLint v10, errors property in valid test case throws error, so I've removed it.

Ref: https://eslint.org/docs/next/use/migrate-to-10.0.0#stricter-rule-tester

@lumirlumir lumirlumir marked this pull request as ready for review December 2, 2025 17:21
@lumirlumir
Copy link
Member Author

Counterpart PR in eslint/css: eslint/css#337

"license": "Apache-2.0",
"dependencies": {
"@eslint/core": "^0.17.0",
"@eslint/core": "^1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a dependency, will this affect end users who are still using ESLint v9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants