ci: ensure ESLint works with at least 9.15.0 and pre-releases
#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive ESLint version testing to the CI workflow to ensure compatibility with the minimum required version (9.15.0), the latest 9.x release, and ESLint v10 pre-releases.
Changes:
- Added an
eslintmatrix dimension to test against versions 9.15.0, 9.x, and ^10.0.0-rc.0 on Ubuntu - Added a new CI step to install the specific ESLint version from the matrix
- Configured Windows and macOS tests to use the latest ESLint version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've ensured ESLint works with at least
9.15.0,9.xlatest version, and in pre-releases.I've mostly followed the same CI matrix convention used in the Markdown repository: https://github.com/eslint/markdown/blob/main/.github/workflows/ci.yml#L46-L75
9.15.0Although
9.15.0is the minimum required ESLint version, tests didn't verify it, so I added a test to confirm compatibility with9.15.0:json/README.md
Line 7 in 368c47b
9.x:Previously the version wasn't specified, so
^9.39.2(the latest v9 release) was always installed. I added a test to confirm compatibility with the latest v9.json/package.json
Line 78 in 368c47b
^10.0.0-rc.0We've gone through the breaking changes mentioned in #184, and as far as I know the primary focus was compatibility with ESLint v10. However, it wasn't tested against ESLint v10 locally since the local ESLint version was v9, so I've added it to ensure compatibility.
Just for reference,
eslint@^10.0.0-rc.0includes the stable10.0.0release, so tests will automatically run against10.0.0once it is released. (We can also update the range to10.xlater if desired.)What changes did you make? (Give an overview)
In this PR, I've ensured ESLint works with at least
9.15.0,9.xlatest version, and in pre-releases.Related Issues
N/A
Is there anything you'd like reviewers to focus on?
N/A