docs: Add sponsors to README #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
documentation
fasttime
reviewed
Oct 5, 2024
tools/update-readme.js
Outdated
| // Main | ||
| //----------------------------------------------------------------------------- | ||
|
|
||
| (async () => { |
Member
Author
There was a problem hiding this comment.
Not really, it just survived through multiple copy-pastes from the original code in eslint/eslint, which is in a cjs module so top-level await was not available. I removed it now.
amareshsm
reviewed
Oct 6, 2024
| const SPONSORS_URL = | ||
| "https://raw.githubusercontent.com/eslint/eslint.org/main/includes/sponsors.md"; | ||
|
|
||
| const README_FILE_PATH = "./README.md"; |
Member
There was a problem hiding this comment.
Suggested change
| const README_FILE_PATH = "./README.md"; | |
| const README_FILE_PATH = "./README.md"; |
Suggestion: Can we use an absolute path here? If we're testing locally from the "tools" directory and run this file using a relative path, it may throw an error. An absolute path would provide consistency in all cases, ensuring the file is accessed correctly regardless of the current working directory.
Member
There was a problem hiding this comment.
since we are not going to run this manually so using a relative path is also okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Adds sponsors to README.md.
What changes did you make? (Give an overview)
Added a script and a workflow that automatically updates sponsors every day.
Related Issues
Is there anything you'd like reviewers to focus on?