Skip to content

chore: use defineConfig and globalIgnores in ESLint config #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nzakas merged 7 commits into from
May 5, 2025
Merged

chore: use defineConfig and globalIgnores in ESLint config #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6a9823c
chore: use `defineConfig` and `globalIgnores` in ESLint config
lumirlumir Apr 26, 2025
995c2e1
wip: add `extends` field
lumirlumir Apr 26, 2025
e70bc6d
Merge branch 'main' into chore-use-define-config-and-global-ignores-i…
lumirlumir Apr 30, 2025
5da7bcb
wip: resolve comments
lumirlumir May 4, 2025
717ec57
Merge branch 'main' into chore-use-define-config-and-global-ignores-i…
lumirlumir May 4, 2025
d8b46d5
wip: resolve comments
lumirlumir May 4, 2025
7454f33
Merge branch 'chore-use-define-config-and-global-ignores-in-eslint-co…
lumirlumir May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import eslintConfigESLint from "eslint-config-eslint";
import eslintPlugin from "eslint-plugin-eslint-plugin";
import json from "./src/index.js";
import { defineConfig, globalIgnores } from "eslint/config";

//-----------------------------------------------------------------------------
// Helpers
Expand All @@ -28,20 +29,19 @@ const eslintPluginTestsRecommendedConfig =
// Configuration
//-----------------------------------------------------------------------------

export default [
{
ignores: ["**/tests/fixtures/", "**/dist/"],
},
export default defineConfig([
globalIgnores(["**/tests/fixtures/", "**/dist/"]),

...eslintConfigESLint.map(config => ({
files: ["**/*.js"],
...config,
})),
{
plugins: { json },
files: ["**/*.json"],
ignores: ["**/package-lock.json"],
language: "json/json",
...json.configs.recommended,
extends: ["json/recommended"],
},
{
files: ["**/*.js"],
Expand Down Expand Up @@ -75,9 +75,8 @@ export default [
},
{
files: ["src/rules/*.js"],
...eslintPluginRulesRecommendedConfig,
extends: [eslintPluginRulesRecommendedConfig],
rules: {
...eslintPluginRulesRecommendedConfig.rules,
"eslint-plugin/require-meta-schema": "off", // `schema` defaults to []
"eslint-plugin/prefer-placeholders": "error",
"eslint-plugin/prefer-replace-text": "error",
Expand All @@ -90,9 +89,8 @@ export default [
},
{
files: ["tests/rules/*.test.js"],
...eslintPluginTestsRecommendedConfig,
extends: [eslintPluginTestsRecommendedConfig],
rules: {
...eslintPluginTestsRecommendedConfig.rules,
"eslint-plugin/test-case-property-ordering": [
"error",
[
Expand All @@ -109,4 +107,4 @@ export default [
"eslint-plugin/test-case-shorthand-strings": "error",
},
},
];
]);
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"devDependencies": {
"c8": "^9.1.0",
"dedent": "^1.5.3",
"eslint": "^9.23.0",
"eslint": "^9.25.1",
"eslint-config-eslint": "^11.0.0",
"eslint-plugin-eslint-plugin": "^6.3.2",
"got": "^14.4.2",
Expand Down