fix: accept inputs from the caller workflow to fix pnpm CI failure#60
Open
lumirlumir wants to merge 6 commits into
Open
fix: accept inputs from the caller workflow to fix pnpm CI failure#60lumirlumir wants to merge 6 commits into
lumirlumir wants to merge 6 commits into
Conversation
f0520da to
81961ba
Compare
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable ci-package-manager GitHub Actions workflow to accept an optional caller-provided input that controls pnpm’s --allow-build behavior, intended to fix CI failures triggered by pnpm v11’s stricter build-script defaults.
Changes:
- Added a
workflow_callinput (pnpm_allow_build_args) to allow callers to specify packages for pnpm--allow-build. - Updated the pnpm install step to conditionally include
--allow-build=...when that input is provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR fixes an issue where CI on the
mainbranch ofgenerator-eslintis failing: https://github.com/eslint/generator-eslint/actions/runs/26231391017/job/77192617767?pr=270As of
pnpmv11, thepostinstallbuild script checks have been enhanced for security reasons, and thegenerator-eslintpackage was affected.What changes did you make? (Give an overview)
This fix requires changes in both the
workflowsandgenerator-eslintrepositories.workflowsI updated the workflow to retrieve the
pnpm_allow_build_argsinput from the caller workflow, in this case,generator-eslint.This input is passed to pnpm’s
--allow-buildflag, and the flag is used only when this input is actually provided.generator-eslintRef: https://github.com/eslint/generator-eslint/pull/270/changes
I updated
generator-eslint’sci-package-managerworkflow to passyoto pnpm’s--allow-buildflag.This PR needs to be merged after that change lands, since this change needs to be applied on the
mainbranch first.The CI on
generator-eslintis all passing: eslint/generator-eslint#270Related Issues
Ref: https://github.com/eslint/generator-eslint/actions/runs/26088324878/job/76707210206
Is there anything you'd like reviewers to focus on?
N/A