Skip to content

fix: accept inputs from the caller workflow to fix pnpm CI failure#60

Open
lumirlumir wants to merge 6 commits into
mainfrom
fix/ci-failure
Open

fix: accept inputs from the caller workflow to fix pnpm CI failure#60
lumirlumir wants to merge 6 commits into
mainfrom
fix/ci-failure

Conversation

@lumirlumir
Copy link
Copy Markdown
Member

@lumirlumir lumirlumir commented May 21, 2026

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR fixes an issue where CI on the main branch of generator-eslint is failing: https://github.com/eslint/generator-eslint/actions/runs/26231391017/job/77192617767?pr=270

As of pnpm v11, the postinstall build script checks have been enhanced for security reasons, and the generator-eslint package was affected.

image

What changes did you make? (Give an overview)

This fix requires changes in both the workflows and generator-eslint repositories.

workflows

I updated the workflow to retrieve the pnpm_allow_build_args input from the caller workflow, in this case, generator-eslint.

This input is passed to pnpm’s --allow-build flag, and the flag is used only when this input is actually provided.

generator-eslint

Ref: https://github.com/eslint/generator-eslint/pull/270/changes

I updated generator-eslint’s ci-package-manager workflow to pass yo to pnpm’s --allow-build flag.

This PR needs to be merged after that change lands, since this change needs to be applied on the main branch first.

The CI on generator-eslint is all passing: eslint/generator-eslint#270

Related Issues

Ref: https://github.com/eslint/generator-eslint/actions/runs/26088324878/job/76707210206

Is there anything you'd like reviewers to focus on?

N/A

@eslint-github-bot eslint-github-bot Bot added the bug Something isn't working label May 21, 2026
@eslintbot eslintbot added this to Triage May 21, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage May 21, 2026
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage May 21, 2026
@lumirlumir lumirlumir changed the title fix: pnpm CI failure caused by approve builds feat: accept inputs from the caller workflow to fix pnpm CI failure caused by approved builds May 21, 2026
@lumirlumir lumirlumir changed the title feat: accept inputs from the caller workflow to fix pnpm CI failure caused by approved builds feat: accept inputs from the caller workflow to fix pnpm CI failure May 21, 2026
@eslint eslint deleted a comment from eslint-github-bot Bot May 21, 2026
@lumirlumir lumirlumir removed the bug Something isn't working label May 21, 2026
@lumirlumir lumirlumir changed the title feat: accept inputs from the caller workflow to fix pnpm CI failure fix: accept inputs from the caller workflow to fix pnpm CI failure May 21, 2026
@eslint-github-bot eslint-github-bot Bot added the bug Something isn't working label May 21, 2026
@lumirlumir lumirlumir requested a review from Copilot May 21, 2026 15:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the reusable ci-package-manager GitHub Actions workflow to accept an optional caller-provided input that controls pnpm’s --allow-build behavior, intended to fix CI failures triggered by pnpm v11’s stricter build-script defaults.

Changes:

  • Added a workflow_call input (pnpm_allow_build_args) to allow callers to specify packages for pnpm --allow-build.
  • Updated the pnpm install step to conditionally include --allow-build=... when that input is provided.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci-package-manager.yml
@lumirlumir lumirlumir marked this pull request as ready for review May 21, 2026 15:16
@lumirlumir lumirlumir moved this from Implementing to Needs Triage in Triage May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants