Skip to content

Fix Angular 17 upgrade #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Angular 17 upgrade #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
723e8f1
Fix Angular 17 upgrade
StevenKolamkuzhiyil Jan 19, 2024
fe7c216
Merge branch 'refs/heads/sync-fork'
StevenKolamkuzhiyil Jul 23, 2024
68572d9
update to angular 17.3.4
StevenKolamkuzhiyil Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,25 @@ https://unpkg.com/@esm-bundle/angular__platform-browser/system/es2022/ivy/angula

#### es2022

https://cdn.jsdelivr.net/npm/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-platform-browser.js
https://cdn.jsdelivr.net/npm/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-animations.js

https://cdn.jsdelivr.net/npm/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-platform-browser.min.js
https://cdn.jsdelivr.net/npm/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-animations.min.js

https://unpkg.com/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-platform-browser.js
https://unpkg.com/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-animations.js

https://unpkg.com/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-platform-browser.min.js
https://unpkg.com/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-animations.min.js

### @angular/platform-browser/animations/async

#### es2022

https://cdn.jsdelivr.net/npm/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-animations-async.js

https://cdn.jsdelivr.net/npm/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-animations-async.min.js

https://unpkg.com/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-animations-async.js

https://unpkg.com/@esm-bundle/angular__platform-browser/system/es2022/ivy/angular-animations-async.min.js

## Specific Version

Expand Down
3 changes: 2 additions & 1 deletion browser-test/systemjs-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ document.head.appendChild(
"rxjs": "https://cdn.jsdelivr.net/npm/@esm-bundle/rxjs/system/es2015/rxjs.min.js",
"rxjs/operators": "https://cdn.jsdelivr.net/npm/@esm-bundle/rxjs/system/es2015/rxjs-operators.min.js",
"@angular/core": "https://cdn.jsdelivr.net/npm/@esm-bundle/angular__core/system/es2022/ivy/angular-core.min.js",
"@angular/core/primitives/signals": "https://cdn.jsdelivr.net/npm/@esm-bundle/angular__core/system/es2022/ivy/angular-signals.min.js",
"@angular/common": "https://cdn.jsdelivr.net/npm/@esm-bundle/angular__common/system/es2022/ivy/angular-common.min.js",
"@angular/common/http": "https://cdn.jsdelivr.net/npm/@esm-bundle/angular__common/system/es2022/ivy/angular-http.min.js",
"@angular/animations": "https://cdn.jsdelivr.net/npm/@esm-bundle/angular__animations/system/es2022/ivy/angular-animations.min.js",
"@angular/animations/browser": "https://cdn.jsdelivr.net/npm/@esm-bundle/angular__animations/system/es2022/ivy/angular-browser.min.js",
"@angular/platform-browser": "/base/system/es2022/ivy/angular-platform-browser.min.js"
}
}`,
})
}),
);
24 changes: 20 additions & 4 deletions browser-test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ describe("@esm-bundle/angular__platform-browser", () => {
describe("@angular/platform-browser", () => {
it("can load the System.register es2022 bundle", async () => {
const m = await System.import(
"/base/system/es2022/ivy/angular-platform-browser.js"
"/base/system/es2022/ivy/angular-platform-browser.js",
);
expect(m.platformBrowser).toBeDefined();
});

it("can load the System.register es2022 prod bundle", async () => {
const m = await System.import(
"/base/system/es2022/ivy/angular-platform-browser.min.js"
"/base/system/es2022/ivy/angular-platform-browser.min.js",
);
expect(m.platformBrowser).toBeDefined();
});
Expand All @@ -18,16 +18,32 @@ describe("@esm-bundle/angular__platform-browser", () => {
describe("@angular/platform-browser/animations", () => {
it("can load the System.register es2022 bundle", async () => {
const m = await System.import(
"/base/system/es2022/ivy/angular-animations.js"
"/base/system/es2022/ivy/angular-animations.js",
);
expect(m.BrowserAnimationsModule).toBeDefined();
});

it("can load the System.register es2022 prod bundle", async () => {
const m = await System.import(
"/base/system/es2022/ivy/angular-animations.min.js"
"/base/system/es2022/ivy/angular-animations.min.js",
);
expect(m.BrowserAnimationsModule).toBeDefined();
});
});

describe("@angular/platform-browser/animations/async", () => {
it("can load the System.register es2022 bundle", async () => {
const m = await System.import(
"/base/system/es2022/ivy/angular-animations-async.js",
);
expect(m.provideAnimationsAsync).toBeDefined();
});

it("can load the System.register es2022 prod bundle", async () => {
const m = await System.import(
"/base/system/es2022/ivy/angular-animations-async.min.js",
);
expect(m.provideAnimationsAsync).toBeDefined();
});
});
});
16 changes: 10 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@esm-bundle/angular__platform-browser",
"version": "17.1.1",
"version": "17.3.4",
"description": "ESM and SystemJS versions of @angular/platform-browser",
"type": "module",
"exports": {
Expand All @@ -11,6 +11,10 @@
"./animations": {
"es2022": "./es2022/ivy/angular-animations.js",
"default": "./es2022/ivy/angular-animations.js"
},
"./animations-async": {
"es2022": "./es2022/ivy/angular-animations-async.js",
"default": "./es2022/ivy/angular-animations-async.js"
}
},
"scripts": {
Expand Down Expand Up @@ -41,11 +45,12 @@
},
"homepage": "https://github.com/esm-bundle/angular__platform-browser#readme",
"devDependencies": {
"@angular/compiler": "17.1.1",
"@angular/compiler-cli": "17.1.1",
"@angular/core": "16.0.3",
"@angular/platform-browser": "17.1.1",
"@angular/compiler": "17.3.4",
"@angular/compiler-cli": "17.3.4",
"@angular/core": "17.3.4",
"@angular/platform-browser": "17.3.4",
"@rollup/plugin-babel": "6.0.4",
"@rollup/plugin-terser": "0.4.4",
"concurrently": "8.2.2",
"esm-bundle-scripts": "1.2.0",
"husky": "9.1.1",
Expand All @@ -59,7 +64,6 @@
"release-it-plugin-esm-bundle": "3.0.0",
"rimraf": "6.0.1",
"rollup": "4.19.0",
"rollup-plugin-terser": "7.0.2",
"rxjs": "7.8.1",
"typescript": "5.5.4"
},
Expand Down
Loading