Adding react-dom/server to @esm-bundle/react-dom #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internettrans
approved these changes
Feb 10, 2021
internettrans
left a comment
internettrans
left a comment
There was a problem hiding this comment.
Looks good to me. Feel free to merge and publish. I've been using this convention for versioning esm bundle repos for versions that only exist to fix esm-bundle (not a bump to react-dom itself) @esm-bundle/react-dom@17.0.1-fix.0
Contributor
Author
|
Awesome. I plan on publishing this today. I will probably also publish it for a few versions of react-dom past:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a problem where we need react-dom server (rich text) and I remembered that we also included it in the import-map at Canopy.