splitting up rollup config. Easier to grok. #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
CreateReactDomConfig
CreateReactDomServerConfig
|
internettrans
approved these changes
Feb 18, 2021
internettrans
left a comment
internettrans
left a comment
There was a problem hiding this comment.
I didn't look over every part of this but the overall refactor seems good. Assuming the tests still pass, I'm happy with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a version of react-dom-server that worked with v16 I had to make a few changes to the rollup config.
In that branch I ended up splitting up the rollup config into composable pieces. It worked really well. This change mirrors that change so that if there is a future incompatibility (like there is a V16 incompatibility) we can more easily update the configuration.