Fix svelte transformer#1357
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the Svelte loader/transformer so that relative imports inside transformed .svelte files resolve correctly during esbuild bundling, addressing issue #1233, and adds a regression test.
Changes:
- Set
ResolveDiron the esbuildOnLoadresults for the Svelte and Vue SFC loaders. - Add a Deno integration test intended to cover issue #1233.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
server/build.go |
Adds ResolveDir to Svelte/Vue esbuild OnLoad results to enable resolving relative imports from transformed SFC code. |
test/issue-1233/test.ts |
Adds a regression test that fetches a .svelte file from @onsvisual/svelte-components and checks the transformed output references the expected dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1233