Added BaseGeoLayer base class#119
Merged
esm7 merged 3 commits intoesm7:masterfrom Jan 14, 2023
Merged
Conversation
Adds BaseGeoLayer that FileMarker extends and in the future a GeoJSON class could be added as well. BaseGeoLayer outlines shared attributes and methods that each subclass must define. Modifies many functions that were previously only aware of the FileMarker class to use BaseGeoLayer. FileMarker only code is moved behind an instance check. Other classes will currently throw an exception. Perhaps in a future pull request that adds GeoJSON support, the class specific code should moved into a method of the class.
Owner
|
Better late than never, thank you for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds BaseGeoLayer that FileMarker extends and in the future a GeoJSON class could be added as well.
BaseGeoLayer outlines shared attributes and methods that each subclass must define.
Modifies many functions that were previously only aware of the FileMarker class to use BaseGeoLayer.
FileMarker only code is moved behind an instance check. Other classes will currently throw an exception.
Perhaps in a future pull request that adds GeoJSON support, the class specific code should moved into a method of the class.
Resolves #109