fix(router-vue): improve router properties configuration and error handling #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndling - Change router properties to be configurable for Vue 3 - Add proper error handling when accessing / without useProvideRouter - Add comprehensive test coverage for router access scenarios - Improve Vue 2/3 compatibility in plugin and router-link components - Add runWithContext test file to verify Vue app context behavior
Deploying esmx with
|
| Latest commit: |
a5d6a15
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c1f5c23.esmx.pages.dev |
| Branch Preview URL: | https://fix-router-vue-properties-an.esmx.pages.dev |
- Add comprehensive test coverage for defineRouterProperties function - Test property definition, getter behavior, and configuration options - Verify non-enumerable and configurable property settings - Test error handling and edge cases - All 13 new tests pass with 100% code coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the router-vue package by enhancing property configuration and error handling:
Checklist