Create a read only way of seeing if a specific route is blocked #185

samoehlert · 2025-11-19T06:03:28Z

Things we still need to do

Clean up resulting output on the API
Double check permissions
Write tests where we add an IP then hit the url to see if it's blocked or not

github-actions · 2025-11-19T06:10:00Z

File	Coverage
All files	`82%`	✅
config/consumers.py	`78%`	✅
config/urls.py	`69%`	✅
config/settings/base.py	`69%`	✅
config/settings/local.py	`72%`	✅
scram/route_manager/admin.py	`71%`	✅
scram/route_manager/models.py	`70%`	✅
scram/route_manager/views.py	`88%`	✅
scram/route_manager/api/serializers.py	`92%`	✅
scram/route_manager/api/views.py	`76%`	✅
scram/shared/shared_code.py	`56%`	✅
scram/templates/403.html	`91%`	✅
scram/templates/404.html	`91%`	✅
scram/templates/base.html	`99%`	✅

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 011a99f

this is meant to be a public endpoint and matches the permissions on the home page to be read only unauthenticated

…py and bad path

WUI already has a search function which points to an entry detail that handles this

…rmat the output to be simpler

samoehlert · 2025-11-20T21:00:54Z

I didn't change anything with behave tests and it seems to be failing instead of ignoring failures on 3.13 like the config says. Not sure if you feel the need to make me figure that out before merging this.

  behave_next_python:
    name: Run Behave
    runs-on: ubuntu-latest
    continue-on-error: true
    strategy:
      max-parallel: 4
      matrix:
        python-version: ['3.13']```

crankynetman

Added a few comments inline. This works great for the exact use-case, but there are some edge cases that might be a bit confusing that I called out inline. I think we should fix the 500 due to submitting a subnet though just with a simple validation in the ViewSet itself if nothing else.

scram/route_manager/api/views.py

…r is missing it was always returning true before which is bad UX at the least

…w which IP is active when searching a larger subnet

… search inside of them 2) add an informational warning if we had to no rmalize the IP as a UX thing 3) make sure to include the actual IP with the response especially important if we return a lit

…response data

…rror trying to create on in github actions

crankynetman

Looks great, I think we just have one more kink to figure out around cidrs. And the answer might be as simple as document it and add it later, but it does seem like an ugly rake to step on later.

scram/route_manager/api/serializers.py

scram/route_manager/api/views.py

also continue renaming is_blocked to is_active

…he rest of SCRAM

crankynetman

Awesome work, nicely done!

soehlert added 3 commits November 18, 2025 23:58

feat(API): add is_blocked API views and serializer

44bf7c3

feat(url): add a path for is_blocked to be in WUI

05d5f54

feat(is_blocked): create an is_blocked view in our WUI views

cdf2d32

samoehlert added the enhancement New feature or request label Nov 19, 2025

samoehlert marked this pull request as draft November 19, 2025 06:03

soehlert added 8 commits November 19, 2025 15:43

feat(API): actually add the endpoint

457cede

fix(import): IsBlockedViewSet won't work if you don't import it

0f8184d

feat(permissions): make this available to anyone without logging in

dfd2247

this is meant to be a public endpoint and matches the permissions on the home page to be read only unauthenticated

test(is_blocked): make sure to test is_blocked endpoint with both hap…

7d7c860

…py and bad path

refactor(WUI): remove is_blocked view from WUI views

452ee00

WUI already has a search function which points to an entry detail that handles this

refactor(WUI): remove URL path from WUI

b6690f2

refactor(API-View): make sure we only accept GET requests and also fo…

377aba8

…rmat the output to be simpler

refactor(ruff): fix ruff errors

5cc37a2

samoehlert marked this pull request as ready for review November 20, 2025 21:00

docs(serializer): update docstring to be more useful

710812f

crankynetman reviewed Dec 2, 2025

View reviewed changes

scram/route_manager/api/views.py Outdated Show resolved Hide resolved

scram/route_manager/api/views.py Outdated Show resolved Hide resolved

scram/route_manager/api/views.py Outdated Show resolved Hide resolved

soehlert added 9 commits December 10, 2025 15:32

docs(typo): fix typo in docstring

6d8fb16

fix(missing-parameter): return a ValidationError when the ip paramete…

d0a243b

…r is missing it was always returning true before which is bad UX at the least

feat(response-fields): add route to the response fields so we can sho…

ccb72b1

…w which IP is active when searching a larger subnet

refactor(is_blocked-responses): fix a few issues. 1) accept cidrs and…

a6aaafd

… search inside of them 2) add an informational warning if we had to no rmalize the IP as a UX thing 3) make sure to include the actual IP with the response especially important if we return a lit

test(update): use the proper parameter name and look for the correct …

48264d5

…response data

style(ruff): fixing ruff errors

0025b16

ci(secret_key): try to hardcode a secret key to avoid the recursion e…

0761a43

…rror trying to create on in github actions

style(ruff): apparently my ruff doesnt find the same as the stuff in CI

bdaeaf6

ci(secret_key): remove hard coded key as that didnt fix it either

4aa754b

crankynetman reviewed Dec 15, 2025

View reviewed changes

scram/route_manager/api/serializers.py Outdated Show resolved Hide resolved

scram/route_manager/api/views.py Show resolved Hide resolved

scram/route_manager/api/views.py Outdated Show resolved Hide resolved

soehlert added 2 commits December 15, 2025 08:47

refactor(warning-message): remove extraneous warning message code

abc5c89

also continue renaming is_blocked to is_active

refactor(is-active): rename is_blocked to is_active to better match t…

011a99f

…he rest of SCRAM

crankynetman approved these changes Dec 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create a read only way of seeing if a specific route is blocked #185

Create a read only way of seeing if a specific route is blocked #185

samoehlert commented Nov 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

samoehlert commented Nov 20, 2025

Uh oh!

crankynetman left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crankynetman left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crankynetman left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Create a read only way of seeing if a specific route is blocked #185

Are you sure you want to change the base?

Create a read only way of seeing if a specific route is blocked #185

Conversation

samoehlert commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samoehlert commented Nov 20, 2025

Uh oh!

crankynetman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crankynetman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crankynetman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

samoehlert commented Nov 19, 2025 •

edited

Loading

github-actions bot commented Nov 19, 2025 •

edited

Loading