fix(Hotfix/soehlert/username): Fill out API username as well as WUI username #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he API data or from the WUI automatically
grigorescu
reviewed
Jul 19, 2023
grigorescu
reviewed
Jul 19, 2023
grigorescu
approved these changes
Jul 19, 2023
Contributor
grigorescu
left a comment
grigorescu
left a comment
There was a problem hiding this comment.
Left one style suggestion (can't tell if it's better or worse), in 2 places. Looks good to me either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were silently dropping the username from the json data in API calls. This meant records coming from automated tools (eg Zeek) were not attributed to anyone. This fixes that while still automatically reading the logged in user from the WUI if an entry is added that way.
Also had to update tests to use the API correctly.