Skip to content

Conversation

@crankynetman
Copy link
Collaborator

This adds support for using a debugger with either VSCode or Pycharm.

I'll add docs before making this out of draft.

@crankynetman crankynetman marked this pull request as draft October 22, 2024 18:57
@crankynetman crankynetman changed the title draft: feat: add debugger for local development feat: add debugger for local development Oct 23, 2024
@crankynetman crankynetman marked this pull request as ready for review October 23, 2024 20:33
samoehlert
samoehlert previously approved these changes Oct 24, 2024
Copy link
Collaborator

@samoehlert samoehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@grigorescu grigorescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reconsider that an invalid value for DEBUG is a fatal error, otherwise this looks great.

Copy link
Collaborator

@samoehlert samoehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Vlad on the error/warning thing.

@crankynetman crankynetman merged commit 7f99060 into main Oct 24, 2024
@crankynetman crankynetman deleted the topic/chriscummings/add-debugger branch October 24, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants