fix(settings.py): Include docker containers in django ALLOWED_HOSTS #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoehlert
approved these changes
Nov 11, 2024
Collaborator
samoehlert
left a comment
samoehlert
left a comment
There was a problem hiding this comment.
This has been much needed, thanks Chris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django ALLOWED_HOSTS (in production) needs to be set in your SCRAM install to allow connections from the django container (for docker compose healthcheck) and the hostname of your actual server (for nginx proxied traffic, like a user hitting the WUI, API calls, etc). So for a typical SCRAM server deployed to production at
scram.example.comyou would needALLOWED_HOSTSto be set toALLOWED_HOSTS = ["django", "scram.example.com"].This uses the
django-environlist type casting to take theDJANGO_ALLOWED_HOSTSenv var and set it to the correct value, for example setting the env var on the system withexport DJANGO_ALLOWED_HOSTS=django,scram.example.comwould result in this in the python settings:ALLOWED_HOSTS = ["django", "scram.example.com"]