Fix issue #22 and simplify project build system#24
Merged
netops2devops merged 2 commits intomainfrom Apr 9, 2026
Merged
Conversation
…o a separate forked repo
lbaker-esnet
approved these changes
Apr 9, 2026
lbaker-esnet
left a comment
There was a problem hiding this comment.
The structure and hygiene work around the upstream dependencies is appreciated, it's much clearer to see what exactly we are patching in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes made in this commit
Before this commit - any patches, fixes, workarounds that we had to apply for fixing known limitations in
step-cawere applied inside a.builddirectory which gets created as a part of Makefilepatch/v0.30.2The patch version tag scheme I am following can be seen in
go.modfileSo if the patches have been applied against upstream v0.30.2 our go.mod should contain
Where the trailing
patch.2indicates total count of patches applied so far i.e two. Should we encounter another another bug in upstream v0.30.2 & have to maintain a third patch then we add our fix to github.com/esnet/certificates under branchpatch/v0.30.2, test it & create a commit tag withv0.30.2-patch.3.Update the go.mod in this repo to point to the new tag