Skip to content

Fix issue #22 and simplify project build system#24

Merged
netops2devops merged 2 commits intomainfrom
fix/issue-22
Apr 9, 2026
Merged

Fix issue #22 and simplify project build system#24
netops2devops merged 2 commits intomainfrom
fix/issue-22

Conversation

@netops2devops
Copy link
Copy Markdown
Contributor

@netops2devops netops2devops commented Apr 9, 2026

The changes made in this commit

  • simplify project build system by taking out patches from Makefile into a separate repo esnet/certificates which is a fork of upstream smallstep/certificates

Before this commit - any patches, fixes, workarounds that we had to apply for fixing known limitations in step-ca were applied inside a .build directory which gets created as a part of Makefile

The patch version tag scheme I am following can be seen in go.mod file

[upstream version]-patch.[count]

So if the patches have been applied against upstream v0.30.2 our go.mod should contain

replace github.com/smallstep/certificates => github.com/esnet/certificates v0.30.2-patch.2

Where the trailing patch.2 indicates total count of patches applied so far i.e two. Should we encounter another another bug in upstream v0.30.2 & have to maintain a third patch then we add our fix to github.com/esnet/certificates under branch patch/v0.30.2, test it & create a commit tag with v0.30.2-patch.3.

git tag -a v0.30.2-patch.3 -m "detailed commit message"
git push --tags v0.30.2-patch.3

Update the go.mod in this repo to point to the new tag

replace github.com/smallstep/certificates => github.com/esnet/certificates v0.30.2-patch.3

@netops2devops netops2devops self-assigned this Apr 9, 2026
Copy link
Copy Markdown

@lbaker-esnet lbaker-esnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure and hygiene work around the upstream dependencies is appreciated, it's much clearer to see what exactly we are patching in.

@netops2devops netops2devops merged commit 6c73665 into main Apr 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants