Make sure Client logs terminating error message inside the JSON output#1146
Merged
bmah888 merged 1 commit intoMay 20, 2021
Conversation
…the JSON output
|
When could this patch commit to master? |
Contributor
|
Thanks for the fix...looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:3.10
Issues fixed (if any):
Non JSON error message at the end of JSON output at the client-side of the measurement #1143
Brief description of code changes (suitable for use as a commit message):
When an active test is terminating with error, make sure the Client logs the error before creating the JSON output, so the error message will be included inside the JSON output.