Do not listen to old UDP prot_listener#1708
Merged
bmah888 merged 1 commit intoesnet:masterfrom Jul 12, 2024
Merged
Conversation
bmah888
approved these changes
Jul 12, 2024
Contributor
bmah888
left a comment
bmah888
left a comment
There was a problem hiding this comment.
Thanks for the pull request! This change looks good, approved. I had mixed results trying to reproduce the performance improvements you saw, but I think this PR makes the functionality of the program more correct regardless.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master
Issues fixed (if any): none
Brief description of code changes (suitable for use as a commit message):
Clear old UDP
prot_listenerfromread_set, as currently the server'sselect()always return when data (that is relevant only to the worker thread) is received. This makes the main thread consume a lot of unnecessary CPU, which reduces the total throughput - especially when only one stream is used.In my single machine environment, with the this fix the throughput is increased by about 40% for one stream test.