feat: [OS-391] make oscars op command netconf ned ready#515
Merged
Conversation
…t NSO esnet-status package response
zrecore
changed the title
disable oauth autoconfiguration for tests correct response parsing now that line breaks are just \n instead of \r\n adjust test environment
…() method, required topo-common version bump to 0.0.35 to support IetfRestconfErrorResponse properties
…eStatusShow() refactor with new NSO API endpoint URI, and bug fixes to handle LiveStatusOutput or IetfRestconfErrorResponse HTTP Post response JSON objects.
…java. Cleaning up NsoProxySteps tests
haniotak
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates NsoProxy.getLiveStatusShow() method to call NSO's
restconf/data/esnet-status:esnet-status/nokia-showendpoint. The device name is no longer supplied as part of the NSO uri, but instead, supplied as a raw data payload to the HTTP POST call.Testing simply calls the NsoProxy.getLiveStatusShow() method, with mocked RestTemplateBuilder.build() and RestTemplate.postForObject() methods to return a mocked JSON payload we load from a file in test resources.
Checklist
type: [OS-XXX] Short descriptiontypeis one of: 'build', 'ci', 'chore', 'docs', 'feat', 'fix', 'perf', 'refactor', 'revert', 'style', 'test'OS-XXXrefers to a Jira issue."BREAKING CHANGE:"and include details in the descriptionmvn clean packageruns successfullyNotes