[codex] Add Dev mode tiered tool exposure#73
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef8aa6c36c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export const AGENT_TOOL_NAMES = new Set(AGENT_TOOLS.map(t => t.function.name)); | ||
| export const RETIRED_AGENT_TOOL_NAMES = new Set(['screenshot', 'full_page_screenshot', 'record_tab', 'stop_recording']); | ||
| export const RESERVED_AGENT_TOOL_NAMES = new Set([...AGENT_TOOL_NAMES, ...RETIRED_AGENT_TOOL_NAMES]); | ||
| export const DEV_ONLY_TOOL_NAMES = new Set(['read_page_source', 'inspect_element_styles']); |
There was a problem hiding this comment.
When inspect_element_styles is made Dev-only here, normal Act runs can still receive trusted recovery nudges that tell the model to call it after no-progress or repeated coordinate clicks (_executeToolBatch appends those warnings in src/chrome/src/agent/agent.js). In Act mode the tool schema no longer includes that name, so these exact failure paths direct the model toward an unavailable tool and the recovery attempt can stall or produce rejected tool calls. Please either keep the tool available where these nudges are emitted or make the nudges conditional on Dev mode.
Useful? React with 👍 / 👎.
|
@codex pls review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f501680dc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const target = asObject(obj.target); | ||
| const type = schedule.type || 'once'; | ||
| const mode = obj.mode === 'ask' ? 'ask' : 'act'; | ||
| const mode = obj.mode === 'ask' ? 'ask' : (obj.mode === 'dev' ? 'dev' : 'act'); |
There was a problem hiding this comment.
Now that validateTaskArgs accepts mode: 'dev', model-created scheduled tasks still cannot request it because the schedule_task tool schema in both browser tool files advertises mode as enum: ['ask', 'act']. With providers that validate tool arguments, a Dev scheduled task requested through the agent will either be rejected or coerced to Act before this validator ever sees it, while the sidepanel-created schedule path can create Dev jobs. Please update the advertised schema alongside this validator so scheduled Dev runs are reachable from the tool.
Useful? React with 👍 / 👎.
|
@codex pls review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
compact | mid | full) and conversation modes (ask | act | dev)test/llmpayload/runners so Dev is a first-class eval modeValidation
git diff --cached --checknpm test