Skip to content

Feature/oneshot adc read all#162

Merged
finger563 merged 4 commits intomainfrom
feature/oneshot-adc-read-all
Mar 1, 2024
Merged

Feature/oneshot adc read all#162
finger563 merged 4 commits intomainfrom
feature/oneshot-adc-read-all

Conversation

@finger563
Copy link
Copy Markdown
Contributor

Description

  • Add new espp::OneshotAdc::read_all_mv() which returns a vector of values for all configured channels.
  • Use new API in example
  • Update how docs are built
  • Update and rebuild docs
  • Update meta-docs (about how to build docs)

Motivation and Context

Simpler API for getting values from all channels that were configured returning a simpler structure (std::vector<int>) rather than an optional per channel. Allows bypass of config existence check by reusing the config stored within the class.

How has this been tested?

Building the example.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Mar 1, 2024
@finger563 finger563 added documentation Improvements or additions to documentation enhancement New feature or request adc labels Mar 1, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit babe34f into main Mar 1, 2024
@finger563 finger563 deleted the feature/oneshot-adc-read-all branch March 1, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adc documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant