feat(joystick): better support for circular joysticks#164
Merged
Conversation
* Refactored joystick so that the difference between RECTANGULAR and CIRCULAR joysticks is clearer and more completely applied * Fixed not clamping output to be within the unit circle if the joystick is CIRCULAR * Updated RangeMapper component to support individually setting the deadband value (around the input center) * Update joystick to set x/y range mapper deadbands to 0 if configured as a CIRCULAR joystick so that only the center_deadzone_radius is applied * rebuild docs
|
✅Static analysis result - no issues found! ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The circularization of the deadzone for the joystick was an incomplete implementation. This fixes that by ensuring the output is circular (clamped to be within the unit circle) and ensures that the center deadzone is consistent and easy to set (just a single deadzone radius value that fully overrides the individual range mapper deadzone values). Breaking updates to the API to bettery convey meaning and intent.
How has this been tested?
Building the joystick example.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.