Skip to content

Conversation

@finger563
Copy link
Contributor

Description

Fix response_data.starts_with("RTSP/1.0") check in RtspClient::parse_response which had a logic inversion.

Motivation and Context

This check is required for the rtsp client to properly communicate with the server.

How has this been tested?

Building and running within the camera-display project, as part of esp-cpp/camera-display#8

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Aug 15, 2024
@finger563 finger563 added bug Something isn't working rtsp labels Aug 15, 2024
@github-actions
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit dffe2ca into main Aug 15, 2024
@finger563 finger563 deleted the fix/rtsp-client branch August 15, 2024 14:25
SquaredPotato pushed a commit to smartknob-ha/espp that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working rtsp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant