Skip to content

Conversation

@SquaredPotato
Copy link
Contributor

Description

Add a missing include to es8311.hpp

Motivation and Context

For some reason, only after upgrading to v6.10.0 of platform-espressif32 did we start getting compiler errors on this.

How has this been tested?

First failing pipeline after upgrade:

Pipeline where I've added the #include <cstdint>:

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@github-actions
Copy link

✅Static analysis result - no issues found! ✅

@SquaredPotato
Copy link
Contributor Author

Apparently this is happening because of a change in GCC: https://gcc.gnu.org/gcc-14/porting_to.html

Some C++ Standard Library headers have been changed to no longer include other headers that were being used internally by the library. As such, C++ programs that used standard library components without including the right headers will no longer compile.

The following headers are used less widely in libstdc++ and may need to be included explicitly when compiling with GCC 14:
- <algorithm> (for std::copy_n, std::find_if, std::lower_bound, std::remove, std::reverse, std::sort etc.)
- <cstdint> (for std::int8_t, std::int32_t etc.)

@finger563 finger563 added bug Something isn't working codec labels Jan 29, 2025
@finger563 finger563 merged commit d7c8be6 into esp-cpp:main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working codec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants