feat(esp-box): Move backlight initialization into LCD instead of display#488
Merged
feat(esp-box): Move backlight initialization into LCD instead of display#488
Conversation
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors backlight control in the ESP-Box component by moving backlight initialization from the display layer to the LCD initialization phase. This change allows users to control LCD backlighting without requiring LVGL initialization.
- Moves backlight LED initialization from
initialize_display()toinitialize_lcd() - Replaces display-based backlight control with direct LED control using hardware PWM
- Updates brightness control methods to work directly with the LED component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| components/esp-box/src/video.cpp | Implements LED-based backlight initialization in initialize_lcd() and updates brightness control methods |
| components/esp-box/include/esp-box.hpp | Adds LED member variables for backlight control and updates documentation |
This was referenced Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
initialize_lcdinstead of letting display handle it.Motivation and Context
This allows users to initialize the LCD for display (including backlight) without having to initialize LVGL.
How has this been tested?
Build and run on esp-box
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.