Skip to content

Conversation

@finger563
Copy link
Contributor

Description

  • Moves the touchpad_input initialization from initialize_touch to initialize_display since that's the function that initializes LVGL and the display. Affects the following BSP components:
    • esp-box
    • matouch-rotary-display
    • seeed-studio-round-display
    • t-deck
    • ws-s3-touch

Motivation and Context

Allows cases where you may not want to initialize the display at all, or do not want to initialize LVGL - but would instead rather simply initialize the touch or the touch and LCD.

How has this been tested?

Build the examples in CI.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

…sp-box`, `matouch-rotary-display`, `seeed-studio-round-display`, `t-deck`, and `ws-s3-touch` components
Copilot AI review requested due to automatic review settings September 11, 2025 03:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR allows touch functionality to be used independently of display initialization for several BSP components by moving the touchpad_input initialization from initialize_touch to initialize_display. This change enables use cases where touch functionality is needed without initializing the display or LVGL.

  • Moves touchpad_input initialization from touch initialization to display initialization
  • Removes display dependency warnings from touch initialization functions
  • Updates documentation to reflect that touch can be initialized independently

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
components/ws-s3-touch/src/video.cpp Moves touchpad_input initialization to initialize_display function
components/ws-s3-touch/src/touchpad.cpp Removes touchpad_input initialization and display dependency check
components/ws-s3-touch/include/ws-s3-touch.hpp Updates documentation to remove display dependency warning
components/t-deck/src/t-deck.cpp Moves touchpad_input initialization to display function and removes dependency checks
components/t-deck/include/t-deck.hpp Updates documentation comments for touch initialization
components/seeed-studio-round-display/src/seeed-studio-round-display.cpp Similar changes - moves touchpad_input to display initialization
components/seeed-studio-round-display/include/seeed-studio-round-display.hpp Updates documentation
components/matouch-rotary-display/src/matouch-rotary-display.cpp Moves touchpad_input initialization and removes dependency checks
components/matouch-rotary-display/include/matouch-rotary-display.hpp Updates documentation
components/esp-box/src/video.cpp Adds touchpad_input initialization to display function
components/esp-box/src/touchpad.cpp Removes touchpad_input initialization from touch function
components/esp-box/include/esp-box.hpp Updates documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 9703269 into main Sep 11, 2025
92 of 93 checks passed
@finger563 finger563 deleted the feat/bsp-touch-independent-of-display branch September 11, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants