fix(t-deck): Increase stack size and clean up audio loading code #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the T-Deck example by increasing the LVGL task stack size and refactoring audio loading code for better efficiency and readability. The changes address potential stack overflow issues and eliminate unnecessary file operations.
- Increased LVGL task stack size from default to 6KB to prevent stack overflow
- Refactored audio loading to use direct vector construction instead of file operations
- Changed audio data pointers from
char*touint8_t*for type correctness
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅Static analysis result - no issues found! ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.