feat: Update BSP component manifests to have explicit target support listed #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds target specifications to IDF component manifest files (idf_component.yml) for various board support packages (BSPs), ensuring components explicitly declare their supported ESP32 chip variants. Additionally, two CMakeLists.txt files are updated to include REQUIRED_IDF_TARGETS.
- Adds
targetsfield to 15 component manifest files specifying supported ESP32 chip variants - Updates CMakeLists.txt for seeed-studio-round-display and motorgo-mini to include REQUIRED_IDF_TARGETS
- Ensures consistency between component manifests and CMake configuration
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components/ws-s3-touch/idf_component.yml | Adds esp32s3 target specification |
| components/ws-s3-lcd-1-47/idf_component.yml | Adds esp32s3 target specification |
| components/ws-s3-geek/idf_component.yml | Adds esp32s3 target specification |
| components/wrover-kit/idf_component.yml | Adds esp32 target specification |
| components/t-dongle-s3/idf_component.yml | Adds esp32s3 target specification |
| components/t-deck/idf_component.yml | Adds esp32s3 target specification |
| components/seeed-studio-round-display/idf_component.yml | Adds esp32s3 target specification |
| components/seeed-studio-round-display/CMakeLists.txt | Adds REQUIRED_IDF_TARGETS for esp32s3 |
| components/qtpy/idf_component.yml | Adds esp32 and esp32s3 target specifications |
| components/motorgo-mini/idf_component.yml | Adds esp32s3 target specification |
| components/motorgo-mini/CMakeLists.txt | Adds REQUIRED_IDF_TARGETS for esp32s3 |
| components/matouch-rotary-display/idf_component.yml | Adds esp32s3 target specification |
| components/esp32-timer-cam/idf_component.yml | Adds esp32 target specification |
| components/esp-box/idf_component.yml | Adds esp32s3 target specification |
| components/byte90/idf_component.yml | Adds esp32s3 target specification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.