feat: Auto-init nvs in wifi if wifi nvs storage enabled in config#617
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the wifi component to automatically initialize NVS when WiFi NVS storage is enabled, aiming to remove the need for callers/examples to explicitly initialize NVS before using WiFi.
Changes:
- Auto-initialize NVS from the
espp::Wifisingleton constructor whenCONFIG_ESP32_WIFI_NVS_ENABLEDis set. - Add an
espp::Nvsmember toWifito perform the initialization. - Update the
wificomponent’s CMakeREQUIRESdependencies to include thenvscomponent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| components/wifi/include/wifi.hpp | Adds conditional NVS include + initializes NVS in Wifi constructor; introduces espp::Nvs member. |
| components/wifi/CMakeLists.txt | Switches dependency from nvs_flash to the nvs component. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wificomponent to initialize nvs subsystem if wifi storage into nvs is configured in menuconfigMotivation and Context
Simplifies wifi usage and cleans up boilerplate code some.
How has this been tested?
Build and run wifi example on esp32
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.