Skip to content

bugfix(adc): use calibration data#70

Merged
finger563 merged 1 commit intomainfrom
bugfix/continuous_adc
Jun 20, 2023
Merged

bugfix(adc): use calibration data#70
finger563 merged 1 commit intomainfrom
bugfix/continuous_adc

Conversation

@finger563
Copy link
Contributor

Description

  • Updated ContinuousAdc to create, use, and free calibration data for each channel so that the values returned are actually millivolts instead of raw values like they were.
  • Updated continuous adc task debug logger to be rate limited

Motivation and Context

We expect to get millivolts from the API, not raw values, so this fixes the implementation to actually return calibrated values in millivolts, just like the oneshot adc.

How has this been tested?

Building and running on a board with an NTC and validating that the temperature measured matches the voltage measured which matches the actual temperature.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Updated ContinuousAdc to create, use, and free calibration data for each channel so that the values returned are actually millivolts instead of raw values like they were.
* Updated continuous adc task debug logger to be rate limited
@finger563 finger563 added bug Something isn't working adc labels Jun 20, 2023
@finger563 finger563 merged commit 3922f25 into main Jun 20, 2023
@finger563 finger563 deleted the bugfix/continuous_adc branch June 20, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adc bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant