Merged
Conversation
* Added support for handling ctrl+l commands (clear the screen) * Added support for basic handling of terminal resize events
* Move terminal size query to get_user_input function instead of in constructor to prevent race condition with configuring stdin_stdout * Minor code update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
People like to resize the terminals, this helps ensure they can continue to use the cli after doing so. This also allows them the functionality to clear the screen when they so wish.
How has this been tested?
Building and running the example.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
cli-update-compressed.mp4
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.