Skip to content

Feature/cli#79

Merged
finger563 merged 4 commits intomainfrom
feature/cli
Jun 26, 2023
Merged

Feature/cli#79
finger563 merged 4 commits intomainfrom
feature/cli

Conversation

@finger563
Copy link
Contributor

@finger563 finger563 commented Jun 25, 2023

Description

  • Added support for handling ctrl+l commands (clear the screen)
  • Added support for basic handling of terminal resize events

Motivation and Context

People like to resize the terminals, this helps ensure they can continue to use the cli after doing so. This also allows them the functionality to clear the screen when they so wish.

How has this been tested?

Building and running the example.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

cli-update-compressed.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Added support for handling ctrl+l commands (clear the screen)
* Added support for basic handling of terminal resize events
@finger563 finger563 added enhancement New feature or request cli labels Jun 25, 2023
* Move terminal size query to get_user_input function instead of in constructor to prevent race condition with configuring stdin_stdout
* Minor code update
@finger563 finger563 merged commit 74a1137 into main Jun 26, 2023
@finger563 finger563 deleted the feature/cli branch June 26, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant