Skip to content

Feature/ads7138#85

Merged
finger563 merged 2 commits intomainfrom
feature/ads7138
Jul 11, 2023
Merged

Feature/ads7138#85
finger563 merged 2 commits intomainfrom
feature/ads7138

Conversation

@finger563
Copy link
Contributor

Description

  • Added unordered_map API for getting all the values as an unordered map instead of a vector, making it easier to track / manage many analog inputs
  • Updated config to take two new optional unordered maps specifying the initial output values and drive configurations for the digital output channels, and set them before setting the channel to output.
  • Rebuild docs

Motivation and Context

We may want to set the output drive mode and value at/before setting the pin to output on the ADS7138. We may also wish to get all the analog inputs at once in a structured way - as a map of channel to value instead of as a vector which has a non-configurable order. This PR solves both of those challenges.

How has this been tested?

Building the ads7138 example.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Added unordered_map API for getting all the values as an unordered map instead of a vector, making it easier to track / manage many analog inputs
* Updated config to take two new optional unordered maps specifying the initial output values and drive configurations for the digital output channels, and set them before setting the channel to output.
@finger563 finger563 added enhancement New feature or request adc labels Jul 11, 2023
@finger563 finger563 merged commit 3016379 into main Jul 11, 2023
@finger563 finger563 deleted the feature/ads7138 branch July 11, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adc enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant