Conversation
* Update to allow users to specify whether they want the lineinput / cli to attempt to handle resize events automatically or not * Fixed bug where get_cursor_position / get_terminal_size response information (used by scanf) would get entered into the lineinput and cause unusable bugs X.X * rebuild docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
There was a bug in the cli when handling resize events (which could be triggered by pressing and holding enter as well) which caused input that was intended for scanf to be handled as user input which would result in a positive feedback loop and render the terminal unusable. This fix properly discards all control sequences that are not explicitly asked for in the control sequence switch statement default case.
Additionally, to help future unforeseen bugs that may stem from the resize functionality, I've added an API to the cli and line input classes to allow the user to turn off the automatic handling of terminal resize.
Also updated some of the class documentation to help inform users of these conditions and what to do if they arise.
How has this been tested?
Building and running the cli example
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.