Conversation
* Added missing `static` keyword to global functions defined in fast_math.hpp * Updated static funtions in fast_math and vector2d to have [[maybe_unused]] attribute to prevent spurious compiler warnings if they are not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
statickeyword to global functions defined in fast_math.hppMotivation and Context
In more complex projects where you may include the
fast_mathheader in multiple places, you will end up getting multiple definition errors for the symbols defined infast_math.hpp. This fixes that issue. It also fixes the benign (but annoying) spurious warnings about functions defined but not used such as in the screenshot below.How has this been tested?
Building the math example.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.