Skip to content

Feature/button naming#91

Merged
finger563 merged 2 commits intomainfrom
feature/button-naming
Jul 13, 2023
Merged

Feature/button naming#91
finger563 merged 2 commits intomainfrom
feature/button-naming

Conversation

@finger563
Copy link
Contributor

Description

  • Update button API to allow the task to be named
  • Update timer to just pass config as task name instead of modifying it
  • Update task to initialize logger tag with name_ instead of config.name
  • rebuild docs

Motivation and Context

If you have multiple buttons in your system, you end up getting a lot of Button tasks without being able to tell which is which (which is important when looking at the task view and figuring out how to set the task stack size based on the high water mark).

How has this been tested?

Building the button example.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update button API to allow the task to be named
* Update timer to just pass config as task name instead of modifying it
* Update task to initialize logger tag with name_ instead of config.name
@finger563 finger563 merged commit 88c77d6 into main Jul 13, 2023
@finger563 finger563 deleted the feature/button-naming branch July 13, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant