Conversation
* Fix NDEF BT and BLE OOB pairing records to send the MAC address bytes in reverse order so that readers will be able to assemble them into the correct addresss according to spec. * Update NDEF BLE OOB pairing record to have the long local name be first in the record, which ensures that the name shows up in the popup when android phones read the NDEF record.
* Fix NDEF BT and BLE OOB pairing records to send the MAC address bytes in reverse order so that readers will be able to assemble them into the correct addresss according to spec. * Update NDEF BLE OOB pairing record to have the long local name be first in the record, which ensures that the name shows up in the popup when android phones read the NDEF record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The existing code could create valid NDEF records for BT devices, but the mac address it sent was incorrect. The existing code would create an invalid MAC address EIR for BLE devices, which would prevent readers such as Android phones from parsing the NDEF record appropriately. Removing this extra byte and updating the ordering of the mac address to be in reverse order enables successful OOB pairing with Android devices. Moving the BLE name EIR field to be first ensures that Android devices show the name (instead of an empty string) when showing the popup for NFC OOB pairing.
How has this been tested?
Building and running within another project.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.