Skip to content

bug(cli): fix conversion error#95

Merged
finger563 merged 1 commit intomainfrom
bugfix/int-to-uart-port-t
Jul 19, 2023
Merged

bug(cli): fix conversion error#95
finger563 merged 1 commit intomainfrom
bugfix/int-to-uart-port-t

Conversation

@finger563
Copy link
Contributor

@finger563 finger563 commented Jul 19, 2023

Description

  • Updated cli component so that CONFIG_ESP_CONSOLE_UART_NUM is cast to uart_port_t to prevent compiler warning that is treated as an error with latest esp-idf master branch.

Motivation and Context

With latest compilers installed from esp-idf/master branch (v5.2-dev-1736-ga2d76ad38a) the raw use of CONFIG_ESP_CONSOLE_UART_NUM results in an error about the use of an int as uart_port_t. This PR fixes that by adding an explicit cast.

How has this been tested?

Building the cli example.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Updated cli component so that CONFIG_ESP_CONSOLE_UART_NUM is cast to uart_port_t to prevent compiler warning that is treated as an error with latest esp-idf master branch.
@finger563 finger563 added bug Something isn't working cli labels Jul 19, 2023
@finger563 finger563 merged commit c0aa4e1 into main Jul 19, 2023
@finger563 finger563 deleted the bugfix/int-to-uart-port-t branch July 19, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant